Your Ad Here

Subscribe
 Post #41
 7th April 2009 Last edited by -[ Fizzadar ]-; 7th April 2009 at 07:37PM..
-[ Fizzadar ]-'s Avatar
March 2009
2,211 Posts
I looked at the code. It seems hugely over complicated for basically the same as what my mod does, but instead of your 19kb server file, mine is 7kb... the rest are 2-5kb plugins.

There's a lot of functions which all they do is return a value, why not just get it anyway, and keep names consistent in the first place.

Also, a decent autorun menu looks like:

if SERVER then
	AddCSLuaFile( "autorun/FizzMin.lua" )
	AddCSLuaFile( "FizzMin/cl_FizzMin.lua" )
	include( "FizzMin/sv_FizzMin.lua" )
elseif CLIENT then
	include( "FizzMin/cl_FizzMin.lua" )
end

Still, on the plus side, it works nicely, and it's a neat, very customizable system, don't take my comments too harshly :)
 Post #42
 7th April 2009
Salads's Avatar
November 2008
619 Posts
Let me draw what Nevec is trying to say:



See how the alignment is off on the second picture?
 Post #43
 7th April 2009
Gold Member
Nevec's Avatar
June 2008
2,742 Posts
Let me draw what Nevec is trying to say:

image

See how the alignment is off on the second picture?
That's pretty much what I'm trying to say. I guess I won't have to draw anything tomorrow.
 Post #44
 7th April 2009 Last edited by turck3; 7th April 2009 at 08:06PM..
turck3's Avatar
August 2006
319 Posts
Mk, I see what you mean bout that, I'll fix it.

As for Fizzradar - I already altered it. But the hook is definitely needed and the reload function is mostly for debug purposes. The elements you have in your example are already covered.
This *was* the first file I wrote - so it wasn't very good at first, I admit, I just fixed it to contain what it needs.

Also, most of those functions that "just return things" come in handy. They arn't one line functions that return the same thing every time, they're more complicated then that, they exist to break up the code flow and make it more reusable.
 Post #45
 7th April 2009
Darastrix's Avatar
March 2009
198 Posts
I urge all of you not to take anything Darastrix says to heart. He speaks as a third party and doesn't represent MOOCOW's interests directly. While I appreciate his support, he has an irritating way of going about things most of the time. His solutions are often *not* correct, and that is why on multiple occasions I have spoken to him about letting me make the corrections instead.
Oh you know I only do it to annoy you,especially taking advantage of the fact you can't delete my posts on this forum :P and there *not* correct for a reason.
 Post #46
 7th April 2009 Last edited by Ex777; 7th April 2009 at 08:43PM..
Ex777's Avatar
March 2005
242 Posts
I just installed it on my server and I like it quite a bit, good job. I don't actually mind that the window frames are bigger then they should be, so long as it gets fixed eventually.
 Post #47
 7th April 2009
turck3's Avatar
August 2006
319 Posts
I'm working on that right now :)

I actually did that on purpose originally to test something, I never bothered to lower it back... anyway, I'm fixing it, so it'll be correct shortly.
 Post #48
 7th April 2009
-[ Fizzadar ]-'s Avatar
March 2009
2,211 Posts
Mk, I see what you mean bout that, I'll fix it.

As for Fizzradar - I already altered it. But the hook is definitely needed and the reload function is mostly for debug purposes. The elements you have in your example are already covered.
This *was* the first file I wrote - so it wasn't very good at first, I admit, I just fixed it to contain what it needs.

Also, most of those functions that "just return things" come in handy. They arn't one line functions that return the same thing every time, they're more complicated then that, they exist to break up the code flow and make it more reusable.
Why is the hook needed? It loads on autorun via include, so why hook it?
 Post #49
 7th April 2009 Last edited by turck3; 7th April 2009 at 09:31PM..
turck3's Avatar
August 2006
319 Posts
It hooks in order to fix an issue involved with umsgs, basically the idea is that if a client joins at the same time the server starts, the server can send the umsgs before the client has loaded their receiving hooks. This way, the client side executes their parts of the mod before the umsgs are sent.

GUI fixed, commiting now. Screenies shortly.
 Post #50
 7th April 2009 Last edited by turck3; 7th April 2009 at 09:30PM..
turck3's Avatar
August 2006
319 Posts
Double post, accident.
 Post #51
 7th April 2009
Gold Member
Killer_Steel's Avatar
October 2007
2,773 Posts
Ok I'm going to admit I DID facepalm at the title. At first, I thought "God damn it ANOTHER admin mod", but now that I look at it it looks pretty detailed, but personally I think there's too many windows. If you've looked at Overv's NewAdmin menu, everything is in one menu, Banning, Actions, and all that. Ulx, 2 clicks to get to the necessary menus plus console AND chat commands. This, it just seems that you open up a menu, click, get another menu, click, get ANOTHER menu, and it continues until the 5th click where you can actually do something, and by that time the minge has already done his damage. What I'm suggesting is: TAKE OUT ALL THE FUCKING MENUS. Mind you I haven't tried this and I'm going on a lookover of the pics.
 Post #52
 7th April 2009
Unib5's Avatar
May 2008
1,710 Posts
This falls into the same mishap ULX does - Too many menus, and ugly interface.

Wherest NewAdmin has a nice tab system with silk icons and simple one click interface.
 Post #53
 7th April 2009
turck3's Avatar
August 2006
319 Posts
Mk. Screenshots replaced with the updated versions.

As for the above, it's faster then you think, the longest chain of GUI windows is 4 clicks, and that's only for banning. Most options are only 1-2 clicks. Example:
blind/bring/burn/freeze/ghost/god/goto/jump/mute/perform/slay/spawn/spawn/spectate/speed/sslay/voicemute/sslay:
1. Click command name
2. Click done (or right click on someone's name)

Others are still not many clicks... things like set/give armor/health are only 2 clicks + moving the sliders if you choose.

Most commands are only 2 clicks. Some are even one, like teleport. I showed the whole layout of ban because it showed several types of screens off.
 Post #54
 7th April 2009
Unib5's Avatar
May 2008
1,710 Posts
Banning is one click in NewAdmin. Select player - ban.
 Post #55
 7th April 2009 Last edited by turck3; 7th April 2009 at 10:12PM..
turck3's Avatar
August 2006
319 Posts
First off, that counts as 2 clicks. Selecting a player, is a click.

That's not necessarily a good thing:
1. Ban reasons? If I'm a server owner, I want to know *why* someone was banned!
2. One thing I don't like about mods like ULX is a command to do something and another to undo it, but in the GUI, I need to separate the two, for obvious reasons.
3. Here's how it breaks down:
a. Click ban
b. Are you banning or unbanning

1. banning (path)

i. select who (multiple player selection allowed for easy use)
ii. Enter a reason optionally and select for how long optionally
iii. Hit done.
2. Unban (path)

i. Click on a line
ii. Hit unban
So it's not things that shouldn't be there. It gives you more control over it. A ban is a commitment, not something to be taken lightly, and thus you should have control over it instead of something that's just rapid fire ban with default settings.

I can go through that entire sequence in 5 seconds.
 Post #56
 7th April 2009
Darastrix's Avatar
March 2009
198 Posts
I have to agree,5 seconds on the gui or 15 seconds trying to remember everything that comes after ban,however for (almost) every other command its useless
 Post #57
 7th April 2009
turck3's Avatar
August 2006
319 Posts
Indeed, chat commands are quick and easy to remember, and for most commands, preferable.
 Post #58
 7th April 2009
Miekk's Avatar
January 2009
243 Posts
It's not useless at all, it's a lot faster than typing the commands.

And if it's such a big deal to all of you, use the chat commands. That is what he made them for.

Instead of complaining, just use the thing that suits you most. Chat commands or the GUI.
 Post #59
 7th April 2009
Darastrix's Avatar
March 2009
198 Posts
It's not useless at all, it's a lot faster than typing the commands.

And if it's such a big deal to all of you, use the chat commands. That is what he made them for.

Instead of complaining, just use the thing that suits you most. Chat commands or the GUI.
Or the console,and its only faster then typing commands if you type slowly,how long does it take you to type

!rocket name

because it takes me roughly 1.2 seconds,and you don't even need the full name :/ but yeah,I still think you should use DComboBox,would make it a lot easier and prettier using the GUI
 Post #60
 7th April 2009
Gold Member
helpiminabox's Avatar
June 2008
2,617 Posts
I may just bring out my old server to try this out. From what I've seen, it looks good... but from what I've heard (a lot of posts in this thread), it may be different.
 Post #61
 7th April 2009
Miekk's Avatar
January 2009
243 Posts
I own a server myself, and admins prefer using the gui over the commands, because they're too lazy to shift positions into typing mode. I would have to say the same thing. You're only counting the time it takes for you to type that, but not switch positions and back. I know it's not much of a real difference, but like I said, it's based on preference.
 Post #62
 7th April 2009
Kidd's Avatar
June 2005
1,408 Posts
I say if the mod works and it does it's job..who cares if it's flashy...Don't use it then.
 Post #63
 7th April 2009
Darastrix's Avatar
March 2009
198 Posts
I own a server myself, and admins prefer using the gui over the commands, because they're too lazy to shift positions into typing mode. I would have to say the same thing. You're only counting the time it takes for you to type that, but not switch positions and back. I know it's not much of a real difference, but like I said, it's based on preference.
What do you mean switch positions?
 Post #64
 7th April 2009
Miekk's Avatar
January 2009
243 Posts
What do you mean switch positions?
The time it takes to move your right(or left) hand from the mouse to the keyboard and your three fingers from asd to asdf
 Post #65
 8th April 2009 Last edited by Darastrix; 8th April 2009 at 12:20AM..
Darastrix's Avatar
March 2009
198 Posts
The time it takes to move your right(or left) hand from the mouse to the keyboard and your three fingers from asd to asdf
actually,the 1.2 seconds was counting that

[color=#FF0000]EDIT: testing if facepunch allows colors[/color]

[color=red]EDIT 2: That didn't work does this[/color]

EDIT 3: facepunch fails

EDIT 4: I figured it out! shame its only red...
 Post #66
 8th April 2009
turck3's Avatar
August 2006
319 Posts
Once again, I'd like to remind everyone that Darastrix has no life and thus nothing better to do then to troll my posts with useless, naive, and wrong statements to piss everyone off, myself at the top of the list. I urge everyone to ignore his ignorance and just continue with your lives. I also urge you not to dignify him with replies, because he feeds on them.
 Post #67
 8th April 2009
Darastrix's Avatar
March 2009
198 Posts
Once again, I'd like to remind everyone that Darastrix has no life and thus nothing better to do then to troll my posts with useless, naive, and wrong statements to piss everyone off, myself at the top of the list. I urge everyone to ignore his ignorance and just continue with your lives. I also urge you not to dignify him with replies, because he feeds on them.
It wasn't you're post,well this is me replying to you're post,and if they don't feed me I'll starve and have to resort to eating live cows,the one in you're picture looks nice,also,do you have to talk about this here?

on a on-topic note:is anyone thinking about doing plugins for moocow? if so,can I suggest

http://wiki.garrysmod.com/wiki/?title=Player.SetDSP
 Post #68
 8th April 2009
Whinis's Avatar
March 2009
28 Posts
Well for one I was a beta tester of moocow and i never came across the problem of the setaccess in fact yesterday ( before updating to version 1.00) i use set access without problems but maybe it was broken when updated to 1.00. I love the admin mod, for me it was easier than any other admin mod and works fairly well. I may not be a coder ( at least in lua) but from what i understand it works very well for little code.

I personally like it not because of GUI ( I can't get it to work sometimes ) but because the commands are so easy to use in chat. I may not run a big server( biggest spike was 4 players) but even I understand the importance of a admin mod that WORKS and works with very little execution ( very few lines of code) working with wiremod if you can take a 50 line E2 code and turn it into a 5 line E2 code it will lag the server less and make more people happy. i assume it works the same way for lua code.
 Post #69
 8th April 2009
Ex777's Avatar
March 2005
242 Posts
I've encountered a small bug, its fairly annoying however. The problem is part of the prop protection plugin, it seems clients can't interact with the world (eg. use constraints on the world, or even spawn duplicated things if they are looking at the world). If you could fix this that would be great.
 Post #70
 8th April 2009 Last edited by turck3; 8th April 2009 at 03:56AM..
turck3's Avatar
August 2006
319 Posts
Alright, I'll fix that. Thanks for letting me know. It should be ready in a few minutes.

EDIT: Commited. Setting "block_world_tool" added to revert to original function (if you need to for any reason)
 Post #71
 8th April 2009 Last edited by Ex777; 8th April 2009 at 07:00AM..
Ex777's Avatar
March 2005
242 Posts
Thanks for being so quick to fix the errors (the very few there may be).
 Post #72
 8th April 2009
Darastrix's Avatar
March 2009
198 Posts
Thanks for being so quick to fix the errors (the very few there may be).
He quickly fixes everything,assuming he knows about the error.
 Post #73
 8th April 2009 Last edited by Unib5; 8th April 2009 at 09:41AM..
Unib5's Avatar
May 2008
1,710 Posts
Besides, NewAdmin looks alot more nicer on the eyes.

Yours:

Overv's:


See what I mean? A simple one menu. No other menus at all. And you also should convert the command names into phrases. freezeall -> Freeze All
 Post #74
 8th April 2009 Last edited by Darastrix; 8th April 2009 at 09:55AM..
Darastrix's Avatar
March 2009
198 Posts
Besides, NewAdmin looks alot more nicer on the eyes.

Yours:

Overv's:


See what I mean? A simple one menu. No other menus at all. And you also should convert the command names into phrases. freezeall -> Freeze All
There's no such command called freeze all,there is however,freeze #client+ which isn't available though the GUI,and turck3 is too stubborn to change the GUI so just give up already :P

EDIT: what does Arm do?
 Post #75
 8th April 2009
Gold Member
Nevec's Avatar
June 2008
2,742 Posts
... and turck3 is too stubborn to change the GUI so just give up already :P
That's pretty much the right attitude.
 Post #76
 8th April 2009
Darastrix's Avatar
March 2009
198 Posts
That's pretty much the right attitude.
XD thanks,but I already knew that
 Post #77
 8th April 2009
Gold Member
Nevec's Avatar
June 2008
2,742 Posts
To execute a command on myself, I had to open the menu, find "perform", select the target, press done, input the command and press done again. Quite a long trip for something so simple. And the forms were popping up at different positions, so I always had to move my mouse to the next control.

I'm sure other commands don't have that much steps. But, in my opinion, most if not all commands should have the same number of steps.
 Post #78
 8th April 2009
Gold Member
kp3's Avatar
January 2008
3,613 Posts
I never knew you were good with lua.
Well done.
 Post #79
 8th April 2009
Darastrix's Avatar
March 2009
198 Posts
To execute a command on myself, I had to open the menu, find "perform", select the target, press done, input the command and press done again. Quite a long trip for something so simple. And the forms were popping up at different positions, so I always had to move my mouse to the next control.

I'm sure other commands don't have that much steps. But, in my opinion, most if not all commands should have the same number of steps.
To execute a command on myself,I had to open the menu, find "perform", right click the target, input the command and press done

1,2,3 clicks
besides,just use chat commands

also,

But, in my opinion, most if not all commands should have the same number of steps.

you're complaining about how many steps perform has yet you want all commands to have extra done buttons to make all steps equal,hypocrite much?
 Post #80
 8th April 2009 Last edited by turck3; 8th April 2009 at 06:08PM..
turck3's Avatar
August 2006
319 Posts
Besides, NewAdmin looks alot more nicer on the eyes.
The idea with MOOCOW is to assume that the server has *no plugins* and base it around that....
New Admin says: I have all the plugins and nobody is going to take them out, so I'm going to make a system that's really bad because I know how it's all going to work la la la la la.

New Admin also says: We don't need to give you options because we know you want the defaults! LESS SCREENS = LESS CONFIGURABILITY = BAD

That's pretty much the right attitude.
Once again, please, please, ignore Darastrix. I'm not saying that I won't change it, I'm saying, you better have a bloody good argument before it happens!

To execute a command on myself, I had to open the menu, find "perform", select the target, press done, input the command and press done again. Quite a long trip for something so simple. And the forms were popping up at different positions, so I always had to move my mouse to the next control.
To execute perform, you can do the following:
1. Open menu - Press perform - Right click on your name - Input command - Press done
2. Open chat - type out "/perform nev say rawr"
3. Open console type out "moocow perform nev say rawr"

Either way, it's not hard. Let me put it this way, does new admin have a cexec or rcon command? Last I checked, it didn't. New Admin can have a GUI like that because it takes no commands that require anything more then just point and click! So ok, you get a few things, kick, ban, slay, slap, but what happens when you want something more then that, say... to save and load teleportation coordinates. Well, I can tell you, I could do that command as a point and click, but then you'd only get one set of save coordinates, and what fun is that?

There is a reason for everything. Method to the madness.

I never knew you were good with lua.
Well done.
Thanks.
Reply

All times are GMT. The time now is 06:28AM.

Facepunch Studios 2010 - Server 'MARGE'