[Blt950]

What is CellMod?

What functions does CellMod give me?
Calling, Texting, Signal Core, and making your own cellphone company!


This is the Signal Frame that you'll see all the time, at the bottom right at your screen.

Calling
Calling function is the most central function in CellMod.
You can /call <player> to start dial, the player then has to approve your call by picking up the phone (/pickup).
Or he can /hangup and don't answer your call.

The calls cost X amount (that is defined by the provider) each minute.

Textmessages
This function will probably mostly used.
You simply /text <player> <text> or /sms

You pay each message sent, the amount is defined by the provider.

Signal Core
This is a core that I made for the CellMod. The basic idea here is that every phone has reception.
The signal core decides how much reception you have, and when you loose it.
It's based on already scripted-in areas from before, and also amount of props around you, if you are in
a area with extremely many props, your reception will drop (It never drops to No Signal state).

I made the reception drop, when you are near very many props. Since then you get this feeling that more stuff, is blocking the signal.
If you try to call someone or text someone, that is inside no-signal area. You'll not be able to send the message or run the call.
If you are in a existing conversation and one of you two enter a no signal area, the conversation will be terminated.
There are currently only already scripted-in areas for signal for rp_downtown_v2 only. Expect more maps in next update!

Make your own cell provider
Make your own company with your own decided prices.
Choose how much a textmessage costs, and per minute a call cost, also
name your company what ever you want!

And give your simcard to other players with /givesim <name> command!
Let's see how many costumers you get!

Download
v.1.2
Doesn't work for G13. Feel free to download it and fix it yourself if you wish

Important Instruction of Install
1. Download the CellMod zip file.
2. Unzip it, and place it correctly in the DarkRP folder (It's zipped just to drag and drop).
3. Enjoy and have fun calling!

Note
The CellMod has not been updated for almost a year, don't expect it to work at all / completly.

License

CellMod by Blt950 is licensed under a Creative Commons Attribution-NonCommercial-NoDerivs 3.0 Unported License.

Changelog
You can find the changelog by clicking here

To-Do List

Future Update Plans
Ideas for next version.

- Remove the default coverage settings. Meaning: The provider needs to build cell towers, to give signal coverage to their clients.
- Cellphone provider company owner gets earning by clients using their service. (Not sure if I already implanted this or not, but it's going to be there)
- A visible counter down in the CellMod frame, showing the current call conversation duration.
- Fix the CellMod not loading properly on each restart of server, and compatible with Gmod 13 DarkRP.
- Make the entities that will be the Cell towers, that gives coverage to clients. A operator's cell tower will only send out his own signals.
- Bad signal will start to break up messages and delay them. Where texts will be simply delayed. 
And conversations would suddenly remove characters/words and breaking it up, and also delay them.
- Monthly payment from clients to owner: This will be X amount each payday probably. It will be optional to have this for companies.
- You can change call/text prices even after you've created the company. Maybe also make different subscriptions for one company?
Like two different ones, one where you pay no "monthly" fee, but calls are more expensive, and opposite. That will be up for you as provider to decide!
- Some sort of animation that shows you're talking in a phone.
- Maybe add a optional function for admins to disable/enable PMing, so people don't use it for free messages.
- A GUI for company owners, and players. Players will have a nice view all sent/recieved text messages, and call history and so on.
The provider owners will have all their company settings in there, such as plans, towers, income, outcome and so on.
- Fix GM:OnPlayerDeath, I overrided the function, instead of hook it.

Thanks to...

Development
Blt950 (me)

Beta Testers
- Torb
- PetruZ
- JamieH
- LiX

Ideas
- Torb
- PetruZ
- Master One

Also thanks to FPtje for some helping, with some tips for the development!

Forgot to add somone? PM me, and I'll fix it

[Gustavgr16]

Nice








I mean the video, Not the addon itself

[Persious]

Actually, this is one of the nicest DarkRP module's I've seen. Surely it can be improved.

[Breny]

Seems like a nifty little thing, it might come in useful :)

[Blt950]

Persious posted:

Actually, this is one of the nicest DarkRP module's I've seen. Surely it can be improved.

Thank you! As I've told, improvements comes now in future updates.
So the updates going to make it more exiting and fun :)

[stadus123]

Amazing!!!! I will use this for my server FTW :D

[czmate10]

Finally not one "admin abuse commands" darkrp module... Congratulations, sir!

[Wolfz]

useless u can use the mic

[FPtje]

I very well appreciate this module.
I was hoping that some day people would make addons for DarkRP. This was a great idea, I'd like to see it in game, so I'll test it.

Great work.

[Breny]

Now there's only one thing left for us to do: find a decent RP server running this addon..

Any test servers?

[Blt950]

Breny posted:

Now there's only one thing left for us to do: find a decent RP server running this addon..

Any test servers?

Indeed; Any servers running CellMod, send me a PM :) I'll list you up here on the main thread, and maybe you will be lucky to get a visit by me sometime :]

[crispylego]

When a user sends a text or calls somebody, where does the money go? Will it go into the Mobile Operator's pocket?

[chuck14]

Now I feel like running a DarkRP server just for this. Good job mister.

[Blt950]

chuck14 posted:

Now I feel like running a DarkRP server just for this. Good job mister.

Thank you :)

crispylego posted:

When a user sends a text or calls somebody, where does the money go? Will it go into the Mobile Operator's pocket?

The money currently don't go anywhere, which is a little fault of my own side to forget to add. This will probably come in the first update v.1.1 :)

[Kopimi]

Really cool module, though you use networked variables in a lot of places that you.. well, don't need to be networking things

I would advise going through your script and checking to make sure that every single NWVar you use has to be access by everyone on the map. If you don't need everyone on the server to be aware of an NWVar, don't use an NWVar.

Also, don't use SendLua so much.
Use usermessages, they're a lot more reliable.

SendLua has a limit to how much data can be transferred per message and sometimes the data will be dropped or cut off at a certain character limit and the client will end up executing an unfinished script.

Other than that, it's a really cool mod, good job :)

EDIT:

Flawless just pointed out that you use Think hooks a lot.. and, well, really poorly actually

You have 3 functions hooked to "Think", which is a bad start.
Think is called each tick, and you're running it on the server, so you'll be lagging the server quite a bit, mostly because in each of the three Think hooks you're calling, you're looping through all the players in the map, which means each tick of the server, you're making the server loop through the players and perform various actions, including modifying networked data, 3 times every tick, which is bad.

In CM.ChangedTeam() you loop through each player on the server (Once again in the Think hook), and then inside an if-statement you're looping through each player AGAIN, in the middle of an ongoing for-loop through each player in the server. Essentially, it's possible that you're looping through every player in the server 3-4 times each tick, PLUS doing an additional loop for every player on the server. That's a lot of loops

function CM.ChangedTeam() -- Somehow the default detect team functions didnt want to co-operate :( So I made this crappy workaround.
	for k,user in pairs(player.GetAll()) do
		if user:Team() == TEAM_MOPERATOR and not user:GetNWBool("cm_config") then
			user:SetNWBool("cm_config", true)
			user:ConCommand("cm_companyconfigwindow")
		elseif user:Team() != TEAM_MOPERATOR and user:GetNWString("cm_company") == user:GetNWString("cm_operator") and user:GetNWString("cm_company") != nil and user:GetNWString("cm_company") != "" and user:GetNWString("cm_operator") != nil and user:GetNWString("cm_operator") != "" then
			for k, v in pairs(player.GetAll()) do
				if v:GetNWString("cm_operator") == user:GetNWString("cm_company") then
					v:SendLua("chat.AddText(Color(255,50,0), 'Your cellphone operator "..user:GetNWString("cm_company").." has been dissolved')")
					v:SendLua("chat.AddText(Color(255,50,0), 'Your current simcard will still work untill you change.')")
				end
			end
			user:SetNWString("cm_operator", "")
			user:SetNWString("cm_company", "")
		elseif user:Team() != TEAM_MOPERATOR then
			user:SetNWBool("cm_config", false)
		end
	end
end
hook.Add("Think", "CM.ChangedTeam", CM.ChangedTeam)

Using the think hook is fine, you just need to know how to control your intervals.
Create a single function hooked to Think, and put all of your current Think hook logic inside that function, then make a variable named "cm_NextTick" and use that to delay the execution of your code, er, here lemme show you:

local cm_NextTick = CurTime()
local cm_TickDelay = 3
function CM.Think()
	if CurTime() >= cm_NextTick then --If it's time to run our tick..
		--Run the code
		cm_NextTick = CurTime() + cm_TickDelay --Delay the next tick
	end
end
hook.Add("Think", "CMThink", CM.Think)

_____

These are all honest mistakes and nobody should be railing on you for making them, but you should definitely fix these issues if you want people to use this addon on their servers.

[LiX]

Really nice module, will definitely run this on my server but I have a little trouble getting it to work properly.
The sounds are not working because you haven't included the sound files in the download and the SIM picture is not showing up - it's just a black/purple square.

Did I install it wrong or did you simply forgot to include some files?

/ LiX

[Fleamonji]

wow, nice

[Juke-Box-Hero]

My server currently is running this addon. I Like it alot. Check it out. It's a build RP server. Just say your from here and youll get a reward :) Server IP: 75.102.41.50:27015

[Bandit Kitteh]

Great, now I can call all my gangsters.

I like calling my gangsters.

[meatwad253]

This is pretty cool, very impressive.

[Blt950]

Kopimi posted:

Really cool module, though you use networked variables in a lot of places that you.. well, don't need to be networking things

I would advise going through your script and checking to make sure that every single NWVar you use has to be access by everyone on the map. If you don't need everyone on the server to be aware of an NWVar, don't use an NWVar.

Also, don't use SendLua so much.
Use usermessages, they're a lot more reliable.

SendLua has a limit to how much data can be transferred per message and sometimes the data will be dropped or cut off at a certain character limit and the client will end up executing an unfinished script.

Other than that, it's a really cool mod, good job :)

EDIT:

Flawless just pointed out that you use Think hooks a lot.. and, well, really poorly actually

You have 3 functions hooked to "Think", which is a bad start.
Think is called each tick, and you're running it on the server, so you'll be lagging the server quite a bit, mostly because in each of the three Think hooks you're calling, you're looping through all the players in the map, which means each tick of the server, you're making the server loop through the players and perform various actions, including modifying networked data, 3 times every tick, which is bad.

In CM.ChangedTeam() you loop through each player on the server (Once again in the Think hook), and then inside an if-statement you're looping through each player AGAIN, in the middle of an ongoing for-loop through each player in the server. Essentially, it's possible that you're looping through every player in the server 3-4 times each tick, PLUS doing an additional loop for every player on the server. That's a lot of loops

function CM.ChangedTeam() -- Somehow the default detect team functions didnt want to co-operate :( So I made this crappy workaround.
	for k,user in pairs(player.GetAll()) do
		if user:Team() == TEAM_MOPERATOR and not user:GetNWBool("cm_config") then
			user:SetNWBool("cm_config", true)
			user:ConCommand("cm_companyconfigwindow")
		elseif user:Team() != TEAM_MOPERATOR and user:GetNWString("cm_company") == user:GetNWString("cm_operator") and user:GetNWString("cm_company") != nil and user:GetNWString("cm_company") != "" and user:GetNWString("cm_operator") != nil and user:GetNWString("cm_operator") != "" then
			for k, v in pairs(player.GetAll()) do
				if v:GetNWString("cm_operator") == user:GetNWString("cm_company") then
					v:SendLua("chat.AddText(Color(255,50,0), 'Your cellphone operator "..user:GetNWString("cm_company").." has been dissolved')")
					v:SendLua("chat.AddText(Color(255,50,0), 'Your current simcard will still work untill you change.')")
				end
			end
			user:SetNWString("cm_operator", "")
			user:SetNWString("cm_company", "")
		elseif user:Team() != TEAM_MOPERATOR then
			user:SetNWBool("cm_config", false)
		end
	end
end
hook.Add("Think", "CM.ChangedTeam", CM.ChangedTeam)

Using the think hook is fine, you just need to know how to control your intervals.
Create a single function hooked to Think, and put all of your current Think hook logic inside that function, then make a variable named "cm_NextTick" and use that to delay the execution of your code, er, here lemme show you:

local cm_NextTick = CurTime()
local cm_TickDelay = 3
function CM.Think()
	if CurTime() >= cm_NextTick then --If it's time to run our tick..
		--Run the code
		cm_NextTick = CurTime() + cm_TickDelay --Delay the next tick
	end
end
hook.Add("Think", "CMThink", CM.Think)

_____

These are all honest mistakes and nobody should be railing on you for making them, but you should definitely fix these issues if you want people to use this addon on their servers.

Yeah! I'm completly aware of my missuse of NWvars and stuff, I actually started making the module with DarkRPvars instead, then I found out; They didn't want to co-operate with me, heh. So I just made it NWvars.

I've already listed optimizing as a point for v.1.1 update, where I will fix stuff like these double loops, and use Usermessages for SendLua and Vars, and stuff that can be used with it :)

Thanks for the advice anyway!
And also, as I commented in the script it self ".... so I made this crappy workaround" heh.

Edited:

LiX posted:

Really nice module, will definitely run this on my server but I have a little trouble getting it to work properly.
The sounds are not working because you haven't included the sound files in the download and the SIM picture is not showing up - it's just a black/purple square.

Did I install it wrong or did you simply forgot to include some files?

/ LiX

I'm pretty sure they should be included, I had that issue myself, but I fixed it. So I think it should be working.
If you notice I forgot something, then write again. And I'll check it out, maybe it's a bug.

[LiX]

I'm pretty sure they should be included, I had that issue myself, but I fixed it. So I think it should be working.
If you notice I forgot something, then write again. And I'll check it out, maybe it's a bug.

I have been trying to get it to work for a while now but it's not possible.
No sounds and no SIM picture. Could you tell me what you did to fix it?
Hope this will be fixed soon, can't wait! :)

/ LiX

[Blt950]

IMPORTANT

The v.1.1 has been released.
The only change is: I added the missing sounds and material files that I forgot in 1.0 *facepalm*

[FPtje]

When you sent me the PM about overriding the /call thing, I thought you had already tried the playerSay hook.

You haven't O_o

This code demonstrates how to override DarkRP's chat command "/call".

hook.Add("PlayerSay", "CM.Callingstuff", function(ply, text, teamonly, dead) 
	if string.find(text, "/call") then 
		-- Do your stuff here
		return "" -- Return "" to make sure it doesn't show up in chat
	end 
end)

I strongly suggest you check out the Gamemode hooks page to see what hooks are available.

[Juke-Box-Hero]

Blt950 posted:

IMPORTANT

The v.1.1 has been released.
The only change is: I added the missing sounds and material files that I forgot in 1.0 *facepalm*

Thanks, ill release it to my server now. Everyone likes it on there :D

[Blt950]

FPtje posted:

When you sent me the PM about overriding the /call thing, I thought you had already tried the playerSay hook.

You haven't O_o

This code demonstrates how to override DarkRP's chat command "/call".

hook.Add("PlayerSay", "CM.Callingstuff", function(ply, text, teamonly, dead) 
	if string.find(text, "/call") then 
		-- Do your stuff here
		return "" -- Return "" to make sure it doesn't show up in chat
	end 
end)

I strongly suggest you check out the Gamemode hooks page to see what hooks are available.

Oh, heh. Embarrasing to forget something so obvious :/ Well thanks!
Maybe for the v.1.2 update the editing main.lua will be fixed then ;) That's great news :)
I'll test this tomorrow :)

Thanks again.

[Binladen34]

Dark RP needs to be it's own game or something. Supporting hundreds of players.

[Kopimi]

Blt950 posted:

Oh, heh. Embarrasing to forget something so obvious :/ Well thanks!
Maybe for the v.1.2 update the editing main.lua will be fixed then ;) That's great news :)
I'll test this tomorrow :)

Thanks again.

I'd probably fix looping through the players 3-4 times per tick thing first to be honest

[Blt950]

Kopimi posted:

I'd probably fix looping through the players 3-4 times per tick thing first to be honest

This is getting fixed in the next update 1.2. This will be only a optimization update :)
Going to fix alot of small stuff there, and also bugs if there will be some :)

[ares5566]

Way to complicated to install

[Blt950]

ares5566 posted:

Way to complicated to install

I truly understand. Wait a few days until I release the optimization update.
Then its only drop the files and play :) No more complicated instal then.

[nutnuts]

Great, going to add this to my server, once it launches!

One of the few things that can actually make a serious DarkRP.

[FPtje]

nutnuts posted:

Great, going to add this to my server, once it launches!

One of the few things that can actually make a serious DarkRP.

Train your admins personally, it will help massively as well.
Also make sure they never use admin privileges as playing rights.
By that I mean things like noclip for building, spawning weapons for self etc.

[nutnuts]

FPtje posted:

Train your admins personally, it will help massively as well.
Also make sure they never use admin privileges as playing rights.
By that I mean things like noclip for building, spawning weapons for self etc.

Yeah, I do all of these, my admins have been on duty 3 years now. Some of them aren't the best roleplayers per se, since I recruited them out of sandbox, but they learn.

I am also not intending to have any such priviliges, as it would ruin everything.

But thanks anyway, they are good suggestions.

[stuky4ever]

Cool.

[Twilight]

Awesome! if only more servers used this.

[jamie1130]

This is FUCKING AWESOME SAUCE

[_NewBee]

Neat idea.
But you should take time to review the script. It's kind of messy on most parts.

[nutnuts]

Got broken by the new patch, gotta fix it.

Edited:

I fixed it, these are lines 17-29 of CellMod.lua in gamemodes/DarkRP/modules

local function AddDir(dir) // recursively adds everything in a directory to be downloaded by client
	local List = file.FindDir(dir.."/*", true)

	for _, fdir in pairs(List) do
		if fdir != ".svn" then // don't spam people with useless .svn folders
			AddDir(dir.."/"..fdir)
		end
	end
 
	for k,v in pairs(file.Find(dir.."/*", true)) do
		resource.AddFile(dir.."/"..v)
	end
end

It was broken in the newest patch.

[Fleamonji]

By habit you shouldn't be adding every single file there is, check if it's a folder, and if it is, call the function again, otherwise check the extension and if it's a valid model/file then add it..