[LinkTwilight]

I apologize for the following page-strecher.

More Pictures

Album #1
Album #2 (Older, has less features)

Console Commands

• ErrorCleanse_KeepColor [0/1] | Should the replacement retain applied colors?
• ErrorCleanse_KeepTexture [0/1] | Should the replacement retain applied materials?
• ErrorCleanse_DrawNoBounds [0/1] | If the entity has no bounds, should it draw at all?
• ErrorCleanse_ReplaceMissingMat | A test for replacing purple & black material (Experimental!)

Mirror [dropbox]

This started as a proof-of-concept a few months ago, but I hope it's suitable for a formal release now.

[CapsAdmin]

excellent

[rnate]

Awesome, should totally be in GMod by default.

[Darkquer]

That's very useful. You would become a god of lua if you make an addon that downloads the missing model.

[_nonSENSE]

Darkquer posted:

That's very useful. You would become a god of lua if you make an addon that downloads the missing model.

http://www.facepunch.com/threads/1049616

[Grocel]

What is

timer.Create( 'ErrorCleanse.AddErrors', 0.25, 0, ents.GetAll )

at line 96 supposed to do? How it's "fixing entities sometimes not getting OnEntityCreated spawned for them"?
Does OnEntityCreated called again for all entities if you call ents.GetAll?

[Noi]

nice work, mom

[Commander11]

This is awesome, good job!

[LauScript]

This needs to be implemented into the game, would really be nice.

[DrogenViech]

Enabling LOD on the missing model box texture would be awesome though

[LinkTwilight]

Grocel posted:

What is

timer.Create( 'ErrorCleanse.AddErrors', 0.25, 0, ents.GetAll )

at line 96 supposed to do? How it's "fixing entities sometimes not getting OnEntityCreated spawned for them"?
Does OnEntityCreated called again for all entities if you call ents.GetAll?

Yeah it's pretty weird - here's why I'm doing that.
Sometimes props (usually small ones?) don't get OnEntityCreated called for them at first. Instead, they get called when you go near them.

I found that calling ents.GetAll will call OnEntityCreated for all the entities that it didn't get it called earlier.

Before calling ents.GetAll: http://i.imgur.com/scjHO.jpg
After calling ents.GetAll: http://i.imgur.com/oJTm9.jpg

I didn't like putting a repeating timer in the script - but I did some tests and ents.GetAll runs so fast that I don't think it's a problem.

[Grocel]

Did you post a bug report or something to Garry about this bug in OnEntityCreated?

[LinkTwilight]

Grocel posted:

Did you post a bug report or something to Garry about this bug in OnEntityCreated?

No I haven't, it didn't seem very important.

Edited:

Oh lord I noticed a huge problem (related to lua effects not drawing)
Please update if you downloaded

[Python1320]

By the way, try css weapons without CSS. Quite...irrritating I'd say.

[bassie12]

Atleast this would make things look like something rather than a pile of flashing crap.

[pennerlord]

Valve should imply this in all source games.

[Fisheater]

Awesome.

[LinkTwilight]

Python1320 posted:

By the way, try css weapons without CSS. Quite...irrritating I'd say.

Oh not again.

I added a (lame) fix for that, I will hopefully find a cleaner fix later.

Updating the garrysmod.org download is such a pain, I wish I could just link it to my dropbox file.

[DrogenViech]

Use SVN!!!11

^{Just kidding obviously}

[Phoenixf129]

Would this be able to be packaged into a server addon?

(Not looked at the code)

Just AddCSLuaFile it? :o

[LinkTwilight]

Phoenixf129 posted:

Would this be able to be packaged into a server addon?

(Not looked at the code)

Just AddCSLuaFile it? :o

That should work just fine -- but you'll also want to send models/props/smallcubetrt.mdl and materials/turtle/errorcleanse_opaque.vtf/vmt
(Which is kind of silly to send a model to fix missing models)

[Grocel]

And if you don't send the model you will get an errorception.

[KatNotDinner]

Awesome work! Much easier on the eyes than the flashing crap Valve created. I think this should come shipped with gmod, along with resourcex.

[DarKSunrise]

LinkTwilight posted:

That should work just fine -- but you'll also want to send models/props/smallcubetrt.mdl and materials/turtle/errorcleanse_opaque.vtf/vmt
(Which is kind of silly to send a model to fix missing models)

Can't you just construct a mesh with Lua instead?

[DarkMonkey]

DarKSunrise posted:

Can't you just construct a mesh with Lua instead?

Or steal one from a rectangular object included by default.

[LinkTwilight]

DarKSunrise posted:

Can't you just construct a mesh with Lua instead?

I was doing that originally, but it was much slower to render and had some lighting problems.

DarkMonkey posted:

Or steal one from a rectangular object included by default.

That's true, the closest I could find to a 1x1x1 cube was in PHX, but it was slighty off-center.

[DrogenViech]

LinkTwilight posted:

I was doing that originally, but it was much slower to render and had some lighting problems.



That's true, the closest I could find to a 1x1x1 cube was in PHX, but it was slighty off-center.

I always wonder how that happens? Why are so much models so badly aligned? Like the cargo containers in hl2

[Looter]

This is awesome, thanks. I'm always too lazy to download someones anime construction model yugioh pack.

[Python1320]

That thing surely knows how to stretch

[C0linSSX]

Isn't Gmod in beta for a major update or something?

Garry should really make this official.

[DrogenViech]

It would be even more awesome to approximate props by using tons of tracelines on the server, and then send the data to the clients (And just fall back to the box method if the server part isn't running)

No exact replica or anything, just enough for wheels to appear as hexagons or something

Edited:

Oops, we need the bad reading rating back:

DarKSunrise posted:

Can't you just construct a mesh with Lua instead?

LinkTwilight posted:

I was doing that originally, but it was much slower to render and had some lighting problems.

:(

[buggy715]

This is a great addon. Much better than seeing blinking red 'ERROR's everywhere.

[KatNotDinner]

Does the mod it descrease fps? Cause I haven't looked in the code but checking and rendering stuff every frame might cause some fps drops.

[mil0001]

Better save up your frames then...

[LinkTwilight]

KatNotDinner posted:

Does the mod it descrease fps? Cause I haven't looked in the code but checking and rendering stuff every frame might cause some fps drops.

The box model has a lot less polygons than the error model, it should increase FPS if anything.
You'd probably need a lot of errors for any substantial changes to be visible, though.

[MadDog986]

Phoenixf129 posted:

Would this be able to be packaged into a server addon?

x2

Please :)

[Dennisjehz123]

Could you make this a server addon?.. i'd love to use this for my servr.

[K9blaze]

you know i actually like the missing model house in the vid. With this it will be alot easier to continue doing things without having to worry about something crucial that would be missing, at least not until later.

[LinkTwilight]

I updated ErrorCleanse to work in GMod 13, but it seems that sv_allowcslua defaults to 0. The new workshop download is in the OP, but you won't see any difference unless the server explicitly allows clientside scripts.
You can use Workshop for servers to send it to connecting clients, but that defeats the point of this script. If you're a server owner you should just be sending the actual models to clients.

Unless sv_allowcslua eventually defaults to 1, I'm afraid this addon is almost useless.

However, for those who want it anyway, here's the new download:
http://steamcommunity.com/sharedfile.../?id=104530717

[Grocel]

LinkTwilight posted:

I updated ErrorCleanse to work in GMod 13, but it seems that sv_allowcslua defaults to 0. The new workshop download is in the OP, but you won't see any difference unless the server explicitly allows clientside scripts.
You can use Workshop for servers to send it to connecting clients, but that defeats the point of this script. If you're a server owner you should just be sending the actual models to clients.

Unless sv_allowcslua eventually defaults to 1, I'm afraid this addon is almost useless.

However, for those who want it anyway, here's the new download:
http://steamcommunity.com/sharedfile.../?id=104530717

Persuade Garry to put it in his game. I think that would be a good idea.